Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Use SearchableMultiDropdownField to select Members #2906

Merged
merged 1 commit into from
Dec 14, 2023
Merged

ENH Use SearchableMultiDropdownField to select Members #2906

merged 1 commit into from
Dec 14, 2023

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 23, 2023 •
edited
Loading

@emteknetnz emteknetnz mentioned this pull request Nov 23, 2023
Closed
8 tasks
@emteknetnz emteknetnz force-pushed the pulls/5/selectorfield branch from b371c34 to c56fad7 Compare November 28, 2023 01:28
GuySartorelli
GuySartorelli requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove the $membersMap variable assignment

@emteknetnz
Copy link
Member Author

Have removed $membersMap variable

@emteknetnz emteknetnz marked this pull request as ready for review December 8, 2023 03:26
@emteknetnz emteknetnz changed the title ENH Use SearchableMutliDropdownField to select Members ENH Use SearchableMultiDropdownField to select Members Dec 8, 2023
@emteknetnz emteknetnz force-pushed the pulls/5/selectorfield branch from c56fad7 to d9b39ee Compare December 8, 2023 03:30
GuySartorelli
GuySartorelli requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs a dependency bump for admin and framework.

@emteknetnz emteknetnz force-pushed the pulls/5/selectorfield branch from d9b39ee to 4fd103d Compare December 12, 2023 21:38
@emteknetnz
Copy link
Member Author

Have updated composer.json

GuySartorelli
GuySartorelli requested changes Dec 13, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/selectorfield branch from 4fd103d to 3d94a0e Compare December 13, 2023 01:15
GuySartorelli
GuySartorelli approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once admin and framework PRs are merged

@GuySartorelli GuySartorelli merged commit c908f1d into silverstripe:5 Dec 14, 2023
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/selectorfield branch December 14, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli