Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FixFilePermissionsTask to fix up NULL file permissions from SS3 #250

Merged
merged 4 commits into from
May 2, 2019

Conversation

bergice
Copy link
Contributor

@bergice bergice commented Apr 30, 2019

This just resets the view enum to Inherit for records that have it set to NULL.

This task will be combined with other file migration tasks at some point so we don't have too many of them floating around.

This should also just be necessary after upgrading from SS3 as it is a datafix.

@chillu
Copy link
Member

chillu commented Apr 30, 2019

This should be a subtask of MigrateFileTask, for the same reasons as thumbnail and shortcode migration subtasks. This is part of the overall "4.x file migration", but in some cases you just want to run those tasks in isolation. I don't want people doing 3.x -> 4.x upgrades to start off with running a whole bunch of arbitrary CLI commands to get started :) Can you please rewrite this to be a subtask, based on the work in #235

chillu
chillu previously requested changes Apr 30, 2019
Copy link
Member

@chillu chillu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above :)

src/Dev/FixFilePermissionsTask.php Outdated Show resolved Hide resolved
src/Dev/FixFilePermissionsTask.php Outdated Show resolved Hide resolved
src/Dev/FixFilePermissionsTask.php Outdated Show resolved Hide resolved
tests/php/FixFilePermissionsTaskTest.yml Outdated Show resolved Hide resolved
@bergice
Copy link
Contributor Author

bergice commented Apr 30, 2019

This should be a subtask of MigrateFileTask, for the same reasons as thumbnail and shortcode migration subtasks. This is part of the overall "4.x file migration", but in some cases you just want to run those tasks in isolation. I don't want people doing 3.x -> 4.x upgrades to start off with running a whole bunch of arbitrary CLI commands to get started :) Can you please rewrite this to be a subtask, based on the work in #235

@chillu should we merge https://github.com/silverstripe/silverstripe-framework/pull/8924/files first or do you want me to cherry-pick/rebase on your branch?

@bergice bergice force-pushed the pulls/1/fix-file-permissions branch from f81ecd0 to 9abae4f Compare April 30, 2019 02:07
@chillu
Copy link
Member

chillu commented Apr 30, 2019

I'd say rebase on that PR, rather than cherry pick. Don't let the silverstripe/silverstripe-framework#8924 merge block you for now.

@unclecheese unclecheese changed the base branch from 1 to 1.4 April 30, 2019 03:43
@bergice bergice force-pushed the pulls/1/fix-file-permissions branch from 9abae4f to 8316856 Compare May 1, 2019 02:14
bergice and others added 2 commits May 2, 2019 10:09
@chillu chillu force-pushed the pulls/1/fix-file-permissions branch from 8316856 to 3ab1efd Compare May 1, 2019 22:22
@chillu chillu force-pushed the pulls/1/fix-file-permissions branch from 8ea412e to 64bc117 Compare May 2, 2019 00:16
@chillu chillu force-pushed the pulls/1/fix-file-permissions branch from 64bc117 to 401ed6f Compare May 2, 2019 01:15
@chillu chillu merged commit 236094c into silverstripe:1.4 May 2, 2019
@chillu chillu deleted the pulls/1/fix-file-permissions branch May 2, 2019 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants