-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FixFilePermissionsTask
to fix up NULL
file permissions from SS3
#250
Add FixFilePermissionsTask
to fix up NULL
file permissions from SS3
#250
Conversation
07f66d7
to
f81ecd0
Compare
This should be a subtask of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above :)
@chillu should we merge https://github.com/silverstripe/silverstripe-framework/pull/8924/files first or do you want me to cherry-pick/rebase on your branch? |
f81ecd0
to
9abae4f
Compare
I'd say rebase on that PR, rather than cherry pick. Don't let the silverstripe/silverstripe-framework#8924 merge block you for now. |
9abae4f
to
8316856
Compare
… SS3. Will be ran by `MigrateFileTask` as a subtask
8316856
to
3ab1efd
Compare
8ea412e
to
64bc117
Compare
64bc117
to
401ed6f
Compare
This just resets the view enum to
Inherit
for records that have it set toNULL
.This task will be combined with other file migration tasks at some point so we don't have too many of them floating around.
This should also just be necessary after upgrading from SS3 as it is a datafix.