Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add periodic logging every 100th file iterated #228

Merged
merged 8 commits into from
Apr 18, 2019

Conversation

bergice
Copy link
Contributor

@bergice bergice commented Apr 3, 2019

No description provided.

dnsl48
dnsl48 previously requested changes Apr 4, 2019
src/FileMigrationHelper.php Outdated Show resolved Hide resolved
src/FileMigrationHelper.php Outdated Show resolved Hide resolved
src/FileMigrationHelper.php Outdated Show resolved Hide resolved
@bergice bergice dismissed dnsl48’s stale review April 10, 2019 03:44

Reviewed and pushed new changes.

src/FileMigrationHelper.php Show resolved Hide resolved
Copy link
Contributor

@dnsl48 dnsl48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

src/FileMigrationHelper.php Outdated Show resolved Hide resolved
src/FileMigrationHelper.php Outdated Show resolved Hide resolved
@dnsl48
Copy link
Contributor

dnsl48 commented Apr 11, 2019

@robbieaverill @ScopeyNZ good to merge?

robbieaverill
robbieaverill previously approved these changes Apr 12, 2019
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work

@kinglozzer
Copy link
Member

Looks good, I definitely missed this when upgrading a site this week! Could you squash the commits @bergice? ☺️

@bergice
Copy link
Contributor Author

bergice commented Apr 15, 2019

Squashed, and all good to go! 🚀

src/FileMigrationHelper.php Outdated Show resolved Hide resolved
src/FileMigrationHelper.php Show resolved Hide resolved
src/FileMigrationHelper.php Outdated Show resolved Hide resolved
bergice and others added 3 commits April 17, 2019 17:30
src/FileMigrationHelper.php Outdated Show resolved Hide resolved
@robbieaverill robbieaverill dismissed their stale review April 17, 2019 21:11

The PR has changed a lot, dismissing my review

Copy link
Contributor

@dnsl48 dnsl48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ace

@dnsl48
Copy link
Contributor

dnsl48 commented Apr 18, 2019

@chillu @ScopeyNZ ping

@chillu chillu merged commit 40bf8cd into silverstripe:1 Apr 18, 2019
@chillu chillu deleted the pulls/1/logging branch April 18, 2019 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants