Add warning about failure to remove legacy file

silverstripe · Apr 10, 2019 · 1809691 · 1809691
1 parent 5d94cea
commit 1809691
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/FileMigrationHelper.php b/src/FileMigrationHelper.php
@@ -168,7 +168,11 @@ protected function migrateFile($base, File $file, $legacyFilename)
 
         if (!$useLegacyFilenames) {
             // removing the legacy file since it has been migrated now and not using legacy filenames
-            return unlink($path);
+            $removed = unlink($path);
+            if (!$removed) {
+                $this->logger->warning("$legacyFilename was migrated, but failed to remove the legacy file ($path)");
+            }
+            return $removed;
         }
         return true;
     }