Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Use updated FormField::validate() signature #1508

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz marked this pull request as draft October 31, 2024 23:36
@emteknetnz emteknetnz force-pushed the pulls/3/form-field-valid branch 2 times, most recently from 5c1b1cd to 5df9ab8 Compare November 6, 2024 02:31
@emteknetnz emteknetnz changed the title ENH Use FieldValidator for FormFields API Use updated FormField::validate() signature Nov 13, 2024
@emteknetnz emteknetnz force-pushed the pulls/3/form-field-valid branch from 5df9ab8 to 356b582 Compare November 13, 2024 00:52
@emteknetnz emteknetnz marked this pull request as ready for review November 14, 2024 22:07
code/Forms/UploadField.php Outdated Show resolved Hide resolved
code/Forms/UploadField.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/3/form-field-valid branch 2 times, most recently from b68c9fd to 63318b1 Compare November 21, 2024 05:14
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when all PRs are ready

@emteknetnz emteknetnz force-pushed the pulls/3/form-field-valid branch 3 times, most recently from 6071cd3 to 09381a0 Compare November 27, 2024 21:38
@emteknetnz emteknetnz force-pushed the pulls/3/form-field-valid branch from 09381a0 to 9d3760b Compare December 1, 2024 21:58
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 78379ec into silverstripe:3 Dec 2, 2024
4 of 15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/form-field-valid branch December 2, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants