Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX disable options not working issue on TreeDropdownField #1847

Conversation

priyashantha
Copy link
Contributor

Description

This PR is for fixing an issue related to TreeDropdownField which the disabled options are treated as enabled in the cms field.

Manual testing steps

  • Setup a SilverStripe site for v5.3
  • Checkout the branch for the module
  • Create a test TreeDropdownField for a test model.
  • Use TreeDropdownField::setDisableFunction() to disable some options and check whether they are disabled in CMS.

Issues

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works great locally. Thanks!

@GuySartorelli GuySartorelli merged commit 1229d0f into silverstripe:2.3 Nov 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants