FIX Avoid infinite recursive loop with attributes in schemadata

silverstripe · Nov 15, 2024 · d776f1b · d776f1b
1 parent afc8105
commit d776f1b
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/code/Forms/UsedOnTable.php b/code/Forms/UsedOnTable.php
@@ -187,8 +187,6 @@ public function getAttributes()
         $attributes = [
             'class' => $this->extraClass(),
             'id' => $this->ID(),
-            'data-schema' => json_encode($this->getSchemaData()),
-            'data-state' => json_encode($this->getSchemaState()),
         ];
 
         $attributes = array_merge($attributes, $this->attributes);

diff --git a/templates/SilverStripe/Admin/Forms/UsedOnTable.ss b/templates/SilverStripe/Admin/Forms/UsedOnTable.ss
@@ -1 +1 @@
-<div class="used-on__polyfill-holder $extraClass" $getAttributesHTML('class')></div>
+<div class="used-on__polyfill-holder $extraClass" $getAttributesHTML('class') data-schema="$SchemaData.JSON" data-state="$SchemaState.JSON"></div>
diff --git a/themes/cms-forms/templates/SilverStripe/Forms/SearchableDropdownField.ss b/themes/cms-forms/templates/SilverStripe/Forms/SearchableDropdownField.ss
@@ -1 +1 @@
-<div $AttributesHTML></div>
+<div $AttributesHTML data-schema="$SchemaData.JSON"></div>
diff --git a/themes/cms-forms/templates/SilverStripe/Forms/SearchableMultiDropdownField.ss b/themes/cms-forms/templates/SilverStripe/Forms/SearchableMultiDropdownField.ss
@@ -1 +1 @@
-<div $AttributesHTML></div>
+<div $AttributesHTML data-schema="$SchemaData.JSON"></div>
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<div class="used-on__polyfill-holder $extraClass" $getAttributesHTML('class')></div>
		<div class="used-on__polyfill-holder $extraClass" $getAttributesHTML('class') data-schema="$SchemaData.JSON" data-state="$SchemaState.JSON"></div>
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<div $AttributesHTML></div>
		<div $AttributesHTML data-schema="$SchemaData.JSON"></div>