FIX Do not use recipe-plugin or vendor-plugin to work out cms major #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#199
recipe-plugin and vendor-plugin ^2 both work in CMS 5 + 6, so cannot be used to determine dynamically work the CMS major version of installer any more.
It caused 5.x-dev to be used instead of 6.x-dev on https://github.com/tractorcow-farm/silverstripe-fluent/actions/runs/8011520958/job/21884953244?pr=827
Note the bit in the release process where we update this is from involves copying .cow.pat.json and running
php hardcoded.php
- this is used to add to theINSTALLER_TO_REPO_MINOR_VERSIONS
const. vendor-plugin and recipe-plugin will still appear for this in this and that's fineHowever that isn't used to workout the CMS major version of installer to use in dynamic e.g. major dev branch with no minor branches, instead it's harcoded version out which version of installer to use for a specific module minor branch. This is different from the dynamic approach which is being disabled in this PR