FIX Remove preinstalled psr extension #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the version of PHP 8.1 that ships with ubuntu now has the php8.1-psr extension with bundled with it, at least the one used in github actions CI. We do not install this extension using the setup-php github action
That extension causes the following issue php PHP 8.1 builds only
PHP Fatal error: Declaration of Monolog\Logger::emergency(Stringable|string $message, array $context = []): void must be compatible with PsrExt\Log\LoggerInterface::emergency($message, array $context = []) in /home/runner/work/silverstripe-userforms/silverstripe-userforms/vendor/monolog/monolog/src/Monolog/Logger.php on line 681The solution is to remove the extension - laravel/framework#46165
Example run of this working - https://github.com/emteknetnz/silverstripe-userforms/actions/runs/7121325156/job/19390520149#step:5:81