DOC Add PHP 8.4 support #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
The changelog is meant to point out changes between CMS 5.4 and CMS 6.0 - not just the breaking changes. I think it should be included.
That's a good idea. |
GuySartorelli
requested changes
Dec 3, 2024
emteknetnz
force-pushed
the
pulls/6/php84
branch
from
6a4f1df to
bf56faa
Compare
|
I've added a small section to the 6.0.0 changelog in the same section that talks about mysql support changing |
emteknetnz
force-pushed
the
pulls/6/php84
branch
from
bf56faa to
2acc202
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#331
I don't think we should add a changelog entry for this as it's PHP 8.4 support is simply something that CMS 6 comes with.
If we did want to mention this in the changelog then it seems like we'd need to mention that PHP 8.1 and 8.2 are no longer supported i.e. it's a change from CMS 5