Make OAI record sorting consistent across paginated pages #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianna-blanca
force-pushed
the
bugfix/consistent-sorting-of-oai-records
branch
from
7f04f05 to
1989ad3
Compare
lianna-blanca
force-pushed
the
bugfix/consistent-sorting-of-oai-records
branch
from
1989ad3 to
193fbbc
Compare
chrispenny
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Great unit test! Good use of Reflection 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the default filtering on function
OaiRecords.php fetchOaiRecords()to consistently return results in order of LastEdited ascending, if no filters are in place.At the moment there is no sorting of unfiltered results, and as per this issue, which creates problems as the first page of the PaginatedList is returned in a random order, but the second and later pages are sorted, meaning some items are never visible; see also this LincolnLTL ticket where the client first described the issue.
Kudos again to Tobie for helping me figure out some knotty bits of the phpunit test.