-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: clean up and update ansible, upgrade to mongo 8 #2921
Conversation
dotnet packages for Ubuntu 22.04+ are now maintained in the official, Ubuntu repositories. This PR can be squashed into a single commit with only the subject and no body. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2921 +/- ##
=======================================
Coverage 80.91% 80.91%
=======================================
Files 533 533
Lines 31224 31224
Branches 5085 5063 -22
=======================================
Hits 25265 25265
- Misses 5198 5210 +12
+ Partials 761 749 -12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question!
Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @marksvc)
.gitmodules
line 8 at r1 (raw file):
path = deploy/roles/apache_config url = https://github.com/saygoweb/ansible-role-apache.git branch = master-our
Is it possible to just delete .gitmodules
, instead of clearing it?
Code quote:
[submodule "deploy/roles_common"]
path = deploy/roles_common
url = https://github.com/sillsdev/ops-ansible-common-roles
branch = master
[submodule "deploy/roles/apache_config"]
path = deploy/roles/apache_config
url = https://github.com/saygoweb/ansible-role-apache.git
branch = master-our
I was wondering if that would happen automatically, but I guess not. |
dotnet packages for Ubuntu 22.04+ are now maintained in the official Ubuntu repositories.
8580da5
to
b631edd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @marksvc)
This change is