Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF-3122 Use lambda in all throwError calls #2919

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

josephmyers
Copy link
Collaborator

@josephmyers josephmyers commented Dec 18, 2024

This change is Reviewable

@josephmyers josephmyers marked this pull request as ready for review December 18, 2024 06:54
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.84%. Comparing base (8046571) to head (cb4cc6b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...p/src/app/machine-api/remote-translation-engine.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2919   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files         532      532           
  Lines       31119    31119           
  Branches     5064     5042   -22     
=======================================
  Hits        25158    25158           
  Misses       5210     5210           
  Partials      751      751           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman self-requested a review December 18, 2024 18:18
@pmachapman pmachapman self-assigned this Dec 18, 2024
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thank you - the machine-api code is some of the oldest in SF!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @josephmyers)

@pmachapman pmachapman enabled auto-merge (squash) December 18, 2024 18:23
@pmachapman pmachapman merged commit e3e072a into master Dec 18, 2024
15 checks passed
@pmachapman pmachapman deleted the task/throwError branch December 18, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants