-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF-3123 Update ParatextData to 9.5.0.8 #2917
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2917 +/- ##
==========================================
+ Coverage 80.90% 80.91% +0.01%
==========================================
Files 533 533
Lines 31211 31218 +7
Branches 5084 5084
==========================================
+ Hits 25250 25259 +9
+ Misses 5211 5198 -13
- Partials 750 761 +11 ☔ View full report in Codecov by Sentry. |
02bf004
to
d381eef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 8 files at r1.
Reviewable status: 5 of 8 files reviewed, 1 unresolved discussion (waiting on @pmachapman)
src/SIL.XForge.Scripture/Services/ParatextService.cs
line 357 at r1 (raw file):
Result: SendReceiveResultEnum.Failed or SendReceiveResultEnum.NotUpgraded or SendReceiveResultEnum.ProjectVersionUpgraded,
Maybe we should be checking that the result isn't Succeeded
?
d381eef
to
2d33db6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 8 files reviewed, all discussions resolved (waiting on @Nateowami)
src/SIL.XForge.Scripture/Services/ParatextService.cs
line 357 at r1 (raw file):
Previously, Nateowami wrote…
Maybe we should be checking that the result isn't
Succeeded
?
Done. Thank you - that looks a lot better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 8 files at r1.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @pmachapman)
src/SIL.XForge.Scripture/Services/ParatextService.cs
line 347 at r2 (raw file):
string srResultDescriptions = ExplainSRResults(results); _logger.LogInformation($"SendReceive results: {srResultDescriptions}"); if (!noErrors || !success || (results?.Any(r => r.Result != SendReceiveResultEnum.Succeeded) == true))
If results
is null, doesn't this third thing resolve to null == true
? Do we care about the situation where results
is null?
2d33db6
to
9a8afc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @Nateowami)
src/SIL.XForge.Scripture/Services/ParatextService.cs
line 347 at r2 (raw file):
Previously, Nateowami wrote…
If
results
is null, doesn't this third thing resolve tonull == true
? Do we care about the situation whereresults
is null?
I forgot to invert the condition. Sorry. Fixed (and added cases explicitly mentioned in the code blocks above).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @marksvc)
9a8afc6
to
ac18b3e
Compare
This PR:
Known bugs:
Known behavior change:
Due to the wide range of potential issues, a full regression run should be performed when this is deployed to QA. I have tested core Scripture Forge functionality (updating chapters, notes, and biblical terms), but there is always a risk of change in expected behavior.
This change is