Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to localized sharing help when it is available #2910

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Dec 14, 2024

This change is Reviewable

@Nateowami Nateowami requested a review from pmachapman December 14, 2024 04:23
@Nateowami Nateowami force-pushed the feature/link-localized-sharing-settings-help branch from 014793c to 452273e Compare December 14, 2024 04:24
@pmachapman pmachapman self-assigned this Dec 15, 2024
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Nateowami)


src/SIL.XForge.Scripture/ClientApp/src/app/settings/settings.component.ts line 25 at r1 (raw file):

import { OnlineStatusService } from 'xforge-common/online-status.service';
import { UserService } from 'xforge-common/user.service';
import { ExternalUrlService } from '../../xforge-common/external-url.service';

NIT: Remove the ../../.

Code quote:

'../../xforge-common/external-url.service';

@Nateowami Nateowami force-pushed the feature/link-localized-sharing-settings-help branch from 452273e to 9c89cc5 Compare December 15, 2024 22:12
Copy link
Collaborator Author

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @pmachapman)


src/SIL.XForge.Scripture/ClientApp/src/app/settings/settings.component.ts line 25 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

NIT: Remove the ../../.

Done.

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@3c0cc85). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2910   +/-   ##
=========================================
  Coverage          ?   80.18%           
=========================================
  Files             ?      531           
  Lines             ?    31135           
  Branches          ?     5052           
=========================================
  Hits              ?    24965           
  Misses            ?     5396           
  Partials          ?      774           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

@pmachapman pmachapman merged commit 3f93008 into master Dec 15, 2024
17 checks passed
@pmachapman pmachapman deleted the feature/link-localized-sharing-settings-help branch December 15, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants