-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to localized sharing help when it is available #2910
Link to localized sharing help when it is available #2910
Conversation
014793c
to
452273e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nit.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Nateowami)
src/SIL.XForge.Scripture/ClientApp/src/app/settings/settings.component.ts
line 25 at r1 (raw file):
import { OnlineStatusService } from 'xforge-common/online-status.service'; import { UserService } from 'xforge-common/user.service'; import { ExternalUrlService } from '../../xforge-common/external-url.service';
NIT: Remove the ../../
.
Code quote:
'../../xforge-common/external-url.service';
452273e
to
9c89cc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @pmachapman)
src/SIL.XForge.Scripture/ClientApp/src/app/settings/settings.component.ts
line 25 at r1 (raw file):
Previously, pmachapman (Peter Chapman) wrote…
NIT: Remove the
../../
.
Done.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2910 +/- ##
=========================================
Coverage ? 80.18%
=========================================
Files ? 531
Lines ? 31135
Branches ? 5052
=========================================
Hits ? 24965
Misses ? 5396
Partials ? 774 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)
This change is