-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF-2710 Clean up i18n of book-multi-select #2430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good. This is the first time I have noticed the transloco pipe - it looks like it is more efficient in this case due to using change detection, if I understand the docs correctly?
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmachapman Maybe? I didn't use it for efficiency; I used it because it allowed me to not use the book_select namespace throughout the rest of the file. I would have used the I18nService
, but adding that to the component requires changes to the tests, and it wasn't a trivial change, unfortunately.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)
95ebb22
to
ab40a1d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2430 +/- ##
=======================================
Coverage 77.05% 77.05%
=======================================
Files 513 513
Lines 29434 29434
Branches 4789 4789
=======================================
Hits 22679 22679
Misses 6008 6008
Partials 747 747 ☔ View full report in Codecov by Sentry. |
This change is