Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF-2701 Add i18n for Select label in book multi select #2426

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Apr 22, 2024

This PR adds internationalization for Select label in the book multi select component.


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Apr 22, 2024
Copy link
Collaborator

@nigel-wells nigel-wells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@nigel-wells nigel-wells self-assigned this Apr 23, 2024
@nigel-wells nigel-wells added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Apr 23, 2024
@pmachapman pmachapman changed the title Add i18n for Select label in book multi select SF2701 Add i18n for Select label in book multi select Apr 23, 2024
@pmachapman pmachapman changed the title SF2701 Add i18n for Select label in book multi select SF-2701 Add i18n for Select label in book multi select Apr 23, 2024
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Apr 24, 2024
@Nateowami Nateowami enabled auto-merge (squash) April 24, 2024 13:40
@Nateowami Nateowami merged commit 94c27e0 into master Apr 24, 2024
14 checks passed
@Nateowami Nateowami deleted the fix/SF-2701 branch April 24, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing complete Testing of PR is complete and should no longer hold up merging of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants