Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment cleanup and minor code refactoring in WritingSystems #1368

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

tombogle
Copy link
Contributor

@tombogle tombogle commented Dec 20, 2024

This change is Reviewable

@tombogle tombogle self-assigned this Dec 20, 2024
@tombogle tombogle requested a review from andrew-polk December 20, 2024 18:00
@tombogle tombogle changed the title Tiny amount of comment cleanup and minor code refactoring in WritingSystems Comment cleanup and minor code refactoring in WritingSystems Dec 20, 2024
Copy link

Palaso Tests

     3 files  ±0       3 suites  ±0   15m 4s ⏱️ -46s
 4 837 tests ±0   4 606 ✅ ±0  231 💤 ±0  0 ❌ ±0 
14 022 runs  ±0  13 395 ✅ ±0  627 💤 ±0  0 ❌ ±0 

Results for commit a8eb262. ± Comparison against base commit 7004a47.

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tombogle)

@tombogle tombogle merged commit 7fadd46 into master Dec 20, 2024
7 checks passed
@tombogle tombogle deleted the code-and-comment-cleanup branch December 20, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants