Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved unit tests to eliminate spurious failures #1365

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

tombogle
Copy link
Contributor

@tombogle tombogle commented Nov 8, 2024

These tests formerly relied on clipboard access or Application.DoEvents and actual mouse positions and timing.


This change is Reviewable

…Events and actual mouse positions and timing.
@tombogle tombogle requested a review from andrew-polk November 8, 2024 21:35
@tombogle tombogle self-assigned this Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

LibPalaso Tests

    45 files  ± 0      45 suites  ±0   9m 22s ⏱️ - 2m 33s
 4 843 tests +13   4 612 ✅ +13  231 💤 ±0  0 ❌ ±0 
14 034 runs  +26  13 407 ✅ +26  627 💤 ±0  0 ❌ ±0 

Results for commit 9b80557. ± Comparison against base commit de37405.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tombogle)

Copy link

Palaso Tests

     3 files  ± 0       3 suites  ±0   17m 58s ⏱️ + 1m 42s
 4 837 tests +13   4 606 ✅ +14  231 💤 ±0  0 ❌  - 1 
14 022 runs  +26  13 395 ✅ +27  627 💤 ±0  0 ❌  - 1 

Results for commit e0b575b. ± Comparison against base commit 1c95083.

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tombogle)

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @josephmyers from a discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tombogle)

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @tombogle from a discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tombogle)

@andrew-polk andrew-polk dismissed josephmyers’s stale review November 19, 2024 17:46

He is not available and his concern was addressed.

@tombogle tombogle merged commit 7d09928 into master Nov 19, 2024
7 checks passed
@tombogle tombogle deleted the improve-tests-that-relied-on-real-live-windows-stuff branch November 19, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants