.NET8 for SIL.Lift.Tests #1355
Merged
.NET8 for SIL.Lift.Tests #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This included replacing NMock2 with Moq and rewriting almost the entire ParserTests class. The only downside of the port was the loss of ordering verification. I think it's possible to use MoqSequence to verify order, but it seems less flexible than what we were doing in NMock2. I also changed the base classes for the three matcher classes to their model classes under test, given that Matcher was removed. Those classes become less necessary now, but I don't see a pressing need to refactor them away.
…ensure no verifications have been missed
hahn-kev
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This included replacing NMock2 with Moq and rewriting almost the entire ParserTests class. The only downside of the port was the loss of ordering verification. I think it's possible to use MoqSequence to verify order, but it seems less flexible than what we were doing in NMock2.
I also changed the base classes for the three matcher classes to their model classes under test, given that Matcher was removed. Those classes become less necessary now, but I don't see a pressing need to refactor them away.
This change is