.NET8 SIL.Core.Tests #1348
Merged
.NET8 SIL.Core.Tests #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephmyers
force-pushed
the
net8-core
branch
from
9dab175 to
99d80a9
Compare
Abort() throws an exception immediately (and is generally considered not recommended), where Interrupt() will/should end the thread when it reaches the WaitSleepJoin state. There may be some subtle differences here, but all its tests continue to pass for all three frameworks. Also fixed corresponding tests that were failing with a runtime exception on .NET8
Fixes a build warning in .NET8
tombogle
approved these changes
Oct 11, 2024
hahn-kev
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is