+semver:major #1328: Replaced old SIL logo with approved variants #1342
Conversation
…rectangular variants that include font glyphs Improved layout of the about box when the version string is really long Added optional parameter to AcknowledgementsProvider.CollectAcknowledgements to facilitate excluding System DLLs
There was a problem hiding this comment.
Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @hahn-kev, @jasonleenaylor, and @tombogle)
CHANGELOG.md line 24 at r1 (raw file):
- [SIL.Windows.Forms] Added public enum Widgets.SilLogoVariant - [SIL.Windows.Forms] Added to Widgets.SilResources: AllLogoVariants, GetLogo, and SilLogoRandom (to replace SilLogo101x113) - [SIL.Core] Added macOS supSilLogoTaiHeritage =port for `GlobalMutex`
typo: Something strange happened on this line.
SIL.Windows.Forms/Miscellaneous/SILAboutBox.cs line 43 at r1 (raw file):
/// the build. Typically this would be set in the AssemblyInformationalVersion.</param> /// <param name="logoVariant">If specified, allows caller to indicate particular SIL logo /// variant to display. By default, a\ variant is chosen at random.</param>
typo: errant extraneous backslash
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @hahn-kev and @jasonleenaylor)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
Also, improved layout of the about box when the version string is really long Added optional parameter to AcknowledgementsProvider.CollectAcknowledgements to facilitate excluding System DLLs
This change is