-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added call to GlobalFFOptions.Configure when setting FFprobeFolder. #1333
Conversation
…therwise, the value set is ignored!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tombogle)
SIL.Media/MediaInfo.cs
line 63 at r1 (raw file):
// not be quite true, but if it couldn't find FFprobe in the requested folder, // GetFFProbeBinaryPath just returns the filename with no folder (meaning that // it expects to find it somewhere on the system path).
Sorry; this sentence is too long for me to parse.
I wonder if a comment is even needed.
You configured something, then you verified the configuration worked. It didn't. You throw. Pretty straightforward.
Rather maybe a comment is warranted on why you need to call Configure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @andrew-polk)
SIL.Media/MediaInfo.cs
line 63 at r1 (raw file):
Previously, andrew-polk wrote…
Sorry; this sentence is too long for me to parse.
I wonder if a comment is even needed.
You configured something, then you verified the configuration worked. It didn't. You throw. Pretty straightforward.Rather maybe a comment is warranted on why you need to call Configure?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tombogle)
Otherwise, the value set is ignored!
This change is