Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added call to GlobalFFOptions.Configure when setting FFprobeFolder. #1333

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

tombogle
Copy link
Contributor

@tombogle tombogle commented Aug 1, 2024

Otherwise, the value set is ignored!


This change is Reviewable

@tombogle tombogle added the fix label Aug 1, 2024
@tombogle tombogle requested a review from andrew-polk August 1, 2024 04:01
@tombogle tombogle self-assigned this Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

LibPalaso Tests

   17 files  ±0     17 suites  ±0   7m 55s ⏱️ -16s
4 883 tests ±0  4 652 ✅ ±0  231 💤 ±0  0 ❌ ±0 
4 902 runs  ±0  4 658 ✅ ±0  244 💤 ±0  0 ❌ ±0 

Results for commit ca7143f. ± Comparison against base commit db9df03.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tombogle)


SIL.Media/MediaInfo.cs line 63 at r1 (raw file):

					// not be quite true, but if it couldn't find FFprobe in the requested folder,
					// GetFFProbeBinaryPath just returns the filename with no folder (meaning that
					// it expects to find it somewhere on the system path).

Sorry; this sentence is too long for me to parse.

I wonder if a comment is even needed.
You configured something, then you verified the configuration worked. It didn't. You throw. Pretty straightforward.

Rather maybe a comment is warranted on why you need to call Configure?

Copy link
Contributor Author

@tombogle tombogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @andrew-polk)


SIL.Media/MediaInfo.cs line 63 at r1 (raw file):

Previously, andrew-polk wrote…

Sorry; this sentence is too long for me to parse.

I wonder if a comment is even needed.
You configured something, then you verified the configuration worked. It didn't. You throw. Pretty straightforward.

Rather maybe a comment is warranted on why you need to call Configure?

Done.

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tombogle)

@tombogle tombogle merged commit 269c813 into master Aug 1, 2024
4 of 5 checks passed
@tombogle tombogle deleted the call-globalffoptions-configure branch August 1, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants