Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'bool CanSyncProject' to 'bool IsProjectMember' #1235

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Nov 13, 2024

So, I didn't remove LexAuthUser.IsProjectMember like I said I would. LexAuthUser seems like a nice place for that.

But I think this refactor makes the PermissionService API less confusing.

The old bool CanSyncProject and the new bool IsProjectMember are not equivalent. But there were only 2 places that use bool CanSyncProject and only 1 needed adapting.

  • I also found a place where I had forgotten to pass an overrideUser.
  • I removed the comments from IPermissionService, because they're not necessary now that the API is more intuitive.

Copy link

C# Unit Tests

90 tests  ±0   90 ✅ ±0   5s ⏱️ ±0s
14 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit ab548ec. ± Comparison against base commit 0fcb7ad.

@hahn-kev hahn-kev self-requested a review November 18, 2024 08:21
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one issue I noticed

backend/LexBoxApi/GraphQL/LexQueries.cs Show resolved Hide resolved
@myieye myieye merged commit 11cfab7 into develop Nov 19, 2024
11 checks passed
@myieye myieye deleted the refactor_is-project-member_permission_check branch November 19, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants