Change 'bool CanSyncProject' to 'bool IsProjectMember' #1235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I didn't remove LexAuthUser.IsProjectMember like I said I would. LexAuthUser seems like a nice place for that.
But I think this refactor makes the PermissionService API less confusing.
The old
bool CanSyncProject
and the newbool IsProjectMember
are not equivalent. But there were only 2 places that usebool CanSyncProject
and only 1 needed adapting.overrideUser
.IPermissionService
, because they're not necessary now that the API is more intuitive.