Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run playwright tests in our gha integration test workflow #1132

Merged
merged 22 commits into from
Nov 19, 2024

Conversation

hahn-kev
Copy link
Collaborator

previously only S&R tests were running on each PR, now playwright tests are included

@hahn-kev hahn-kev changed the title chore/playwright-in-gha-k8s Run playwright tests in our gha integration test workflow Oct 17, 2024
@hahn-kev hahn-kev marked this pull request as draft October 18, 2024 07:21
Copy link

github-actions bot commented Oct 29, 2024

UI unit Tests

12 tests   12 ✅  0s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit caf0328.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 29, 2024

C# Unit Tests

90 tests  ±0   90 ✅ ±0   5s ⏱️ ±0s
14 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit caf0328. ± Comparison against base commit 022f8b5.

♻️ This comment has been updated with latest results.

@myieye myieye marked this pull request as ready for review November 18, 2024 13:53
@myieye
Copy link
Contributor

myieye commented Nov 18, 2024

Currently 3 Playwright tests are failing with this request. I'm not sure why:

{
  "errors": [
    {
      "message": "Unexpected Execution Error",
      "locations": [{ "line": 2, "column": 3 }],
      "path": ["updateProjectRepoSizeInKb"],
      "extensions": {
        "message": "Response status code does not indicate success: 400 (Bad Request).",
        "stackTrace": "   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at LexBoxApi.Services.HgService.ExecuteHgCommandServerCommand(ProjectCode code, String command, CancellationToken token) in /LexBoxApi/Services/HgService.cs:line 488
   at LexBoxApi.Services.HgService.GetRepoSizeInKb(ProjectCode code, CancellationToken token) in /LexBoxApi/Services/HgService.cs:line 431
   at LexBoxApi.Services.ProjectService.UpdateRepoSizeInKb(String projectCode) in /LexBoxApi/Services/ProjectService.cs:line 251
   at LexBoxApi.GraphQL.ProjectMutations.UpdateProjectRepoSizeInKb(String code, IPermissionService permissionService, ProjectService projectService, LexBoxDbContext dbContext) in /LexBoxApi/GraphQL/ProjectMutations.cs:line 372
   at HotChocolate.Resolvers.Expressions.ExpressionHelper.AwaitTaskHelper[T](Task`1 task)
   at HotChocolate.Types.Helpers.FieldMiddlewareCompiler.<>c__DisplayClass9_0.<<CreateResolverMiddleware>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at HotChocolate.Types.UnwrapFieldMiddlewareHelper.<>c__DisplayClass0_1.<<CreateDataMiddleware>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at HotChocolate.Data.Projections.FirstOrDefaultMiddleware`1.InvokeAsync(IMiddlewareContext context)
   at HotChocolate.Utilities.MiddlewareCompiler`1.ExpressionHelper.AwaitTaskHelper(Task task)
   at HotChocolate.Types.MutationConventionTypeInterceptor.<>c__DisplayClass16_0.<<ApplyResultMiddleware>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at HotChocolate.Types.MutationConventionMiddleware.InvokeAsync(IMiddlewareContext context)
   at HotChocolate.Types.ErrorMiddleware.InvokeAsync(IMiddlewareContext context)
   at DataAnnotatedModelValidations.Middleware.ValidatorMiddleware.InvokeAsync(IMiddlewareContext context)
   at HotChocolate.Utilities.MiddlewareCompiler`1.ExpressionHelper.AwaitTaskHelper(Task task)
   at HotChocolate.Execution.Processing.Tasks.ResolverTask.ExecuteResolverPipelineAsync(CancellationToken cancellationToken)
   at HotChocolate.Execution.Processing.Tasks.ResolverTask.TryExecuteAsync(CancellationToken cancellationToken)"
      }
    }
  ],
  "data": null
}

@hahn-kev
Copy link
Collaborator Author

hahn-kev commented Nov 19, 2024

@myieye looks like our gha tests were using the latest version of the hgweb image, and not the develop version, and fw-headless wasn't even in the kustomize file, so I fixed those.

@hahn-kev
Copy link
Collaborator Author

wow, they passed twice, I'm going to merge it while it's green lol

@hahn-kev hahn-kev merged commit c23a0bc into develop Nov 19, 2024
14 checks passed
@hahn-kev hahn-kev deleted the chore/playwright-in-gha-k8s branch November 19, 2024 04:03
@myieye
Copy link
Contributor

myieye commented Nov 19, 2024

Could it really be?! Green tests!!! 💚💚
Oh, well done!!!! 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants