Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LT-21970: S/R failure with reordering data entry fields #422

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

jtmaxwell3
Copy link
Contributor

@jtmaxwell3 jtmaxwell3 commented Dec 4, 2024

It couldn't validate:

because of the lack of around the part. I changed the validator and added a unit test for both layout and merge.

This change is Reviewable

Copy link

github-actions bot commented Dec 4, 2024

Test Results

881 tests  +2   767 ✅ +2   3m 26s ⏱️ ±0s
108 suites ±0    25 💤 ±0 
  1 files   ±0     5 ❌ ±0   84 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit 2f394ce. ± Comparison against base commit 5e6d4dd.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, all discussions resolved


src/LibFLExBridge-ChorusPlugin/Handling/ConfigLayout/FieldWorksConfigurationLayoutValidator.cs line 129 at r1 (raw file):

					{
						ValidatePartElement(grandChildElement);
					}

⛏️ When a conditional contains a multi-line statement we prefer to have braces for code readability (on single line conditionals the braces are optional)

Code quote:

				if (childElement.Name.LocalName == "indent")
					foreach (var grandChildElement in childElement.Elements())
					{
						ValidatePartElement(grandChildElement);
					}

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jasonleenaylor jasonleenaylor merged commit 2dcbbb7 into develop Dec 4, 2024
9 of 10 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-21970 branch December 4, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants