Be less strict about FixFwData name and location #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, dotnet compiles binaries to filenames without .exe in them, so we should handle that scenario gracefully. Also, it's common to be running from a different directory than the one where FixFwData.exe is found (e.g., `dotnet run` in the project that calls LfMergeBridge), so we should also check the location of LfMergeBridge.dll since FixFwData will usually be installed alongside LfMergeBridge.dll.
hahn-kev
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #409.
On Linux, dotnet compiles binaries to filenames without .exe in them, so we should handle that scenario gracefully. Also, it's common to be running from a different directory than the one where FixFwData.exe is found (e.g.,
dotnet runin the project that calls LfMergeBridge), so we should also check the location of LfMergeBridge.dll since FixFwData will usually be installed alongside LfMergeBridge.dll.This change is