Signing CD Action #397

jasonleenaylor · 2024-04-17T20:39:17Z

This change is

src/LibFLExBridge-ChorusPluginTests/LibFLExBridge-ChorusPluginTests.csproj

* Add workflow dispatch input * Update to latest overcrowdin version * Update generic installer to handle delayed signing * Build/upload/and sign the msi

* actions/runner-images#9667 * Should be removed as soon as the runner version works

* Download the signed msi artifact and then and build bundles * Add a description parameter for signing

* Also update framework dependency to net48

* Sign engines, reattach engines, upload and sign bundles

megahirt · 2024-06-10T08:59:32Z

This is a monumental effort, @jasonleenaylor nice work! I assume you are happy for this to get merged in with a review and not wait for a signing service to be developed.

jasonleenaylor · 2024-06-11T20:44:44Z

Yes @megahirt I would like to get this merged to use until we have a signing service.

jasonleenaylor · 2024-06-14T19:02:59Z

From Ken Zook:
"It installed. I was able to get project from colleague from LD, and did a S/R project to LD and it worked. I think we have a winner. It's version FLEx Bridge 4.2.0-alpha.20 13/Jun/2024. It has mercurial 6.5.1 installed. Looks like it's ready for the test team to give it a good workout. "

I would like to get some PRs in the codesign repo merged and update this PR with a real tagged version but otherwise it is ready.
sillsdev/codesign#18
sillsdev/codesign#19

megahirt

LGTM

.github/workflows/ci-cd.yml

megahirt · 2024-06-24T06:39:20Z

.github/workflows/ci-cd.yml

        if: github.event_name != 'pull_request'
-
+
+      - name: Downgrade Wix Toolset - remove when runner has 3.14.2


Suggested change

- name: Downgrade Wix Toolset - remove when runner has 3.14.2

- name: Downgrade Wix Toolset - remove when runner has 3.14.2

# See: https://github.com/actions/runner-images/issues/9667

I'd rather put that in a comment rather than make an already-long step name even longer.

good call. I moved it to the next line as a comment

rmunn

I have no experience with WiX so if there are any mistakes in that part of the PR then I won't have caught them. But the GHA workflow changes look good to me.

jasonleenaylor

Dismissed @rmunn from a discussion.
Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @megahirt and @rmunn)

src/LibFLExBridge-ChorusPluginTests/LibFLExBridge-ChorusPluginTests.csproj line 15 at r1 (raw file):

Previously, rmunn (Robin Munn) wrote…

Why this downgrade? SIL.Chorus.Mercurial 6.5.1.25 fixed running Mercurial on Linux under Python 3, and AFAIK made no other changes. Is there something that I broke in creating 6.5.1.25 that was working correctly with 6.5.1.22 which made the downgrade necessary?

Done.

jasonleenaylor

Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @megahirt and @rmunn)

.github/workflows/ci-cd.yml line 56 at r4 (raw file):

Previously, megahirt (Christopher Hirt) wrote…

good call. I moved it to the next line as a comment

Done.

jasonleenaylor

Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @megahirt and @rmunn)

.github/workflows/ci-cd.yml line 23 at r4 (raw file):

Previously, rmunn (Robin Munn) wrote…

It's used by FLExBridge.proj to get the root directory of the project. We should keep it until the TeamCity build is finally gone, then we can rename it both here and in FLExBridge.proj.

Done.

* Also only downgrade WIX when building installers (not PRs)

jasonleenaylor force-pushed the feature/gha-signing branch from b4fefa1 to 53b4343 Compare April 17, 2024 20:44

rmunn reviewed Apr 18, 2024

View reviewed changes

src/LibFLExBridge-ChorusPluginTests/LibFLExBridge-ChorusPluginTests.csproj Outdated Show resolved Hide resolved

jasonleenaylor force-pushed the feature/gha-signing branch 18 times, most recently from f1e5cd0 to 2c77ba7 Compare April 23, 2024 21:28

jasonleenaylor force-pushed the feature/gha-signing branch 10 times, most recently from f4fd936 to af97707 Compare May 6, 2024 19:02

jasonleenaylor force-pushed the feature/gha-signing branch 4 times, most recently from 00bba6a to 6411066 Compare June 7, 2024 04:50

jasonleenaylor added 5 commits June 7, 2024 06:31

Update cd build to support signing of the .msi

5b3043f

* Add workflow dispatch input * Update to latest overcrowdin version * Update generic installer to handle delayed signing * Build/upload/and sign the msi

Roll back the Wix version to fix installer

f066d6f

* actions/runner-images#9667 * Should be removed as soon as the runner version works

Introduce the bundle build into our CD

bf4ef40

* Download the signed msi artifact and then and build bundles * Add a description parameter for signing

Extract wix override copy to enable GHA bundle build

3e43a17

* Also update framework dependency to net48

Run the burn detatch and upload files

fd5146a

jasonleenaylor force-pushed the feature/gha-signing branch from 6411066 to 31b30a2 Compare June 7, 2024 14:01

Complete the CD actions and upload signed FB Installers

5fb1d5b

* Sign engines, reattach engines, upload and sign bundles

jasonleenaylor force-pushed the feature/gha-signing branch from 31b30a2 to 5fb1d5b Compare June 7, 2024 20:18

jasonleenaylor changed the title ~~WIP - Signing CD Action~~ Signing CD Action Jun 7, 2024

Fix crash launching FlexBridge from places other than lexbox

e3c47be

Update sign action tags to release version

79893d7

megahirt approved these changes Jun 24, 2024

View reviewed changes

rmunn approved these changes Jun 24, 2024

View reviewed changes

jasonleenaylor requested review from megahirt and rmunn June 24, 2024 13:24

jasonleenaylor commented Jun 24, 2024

View reviewed changes

jasonleenaylor force-pushed the feature/gha-signing branch from 13a4c82 to eb8605b Compare June 24, 2024 13:45

Remove useles comment and add a link to wix toolset issue

07c39a2

* Also only downgrade WIX when building installers (not PRs)

jasonleenaylor force-pushed the feature/gha-signing branch from eb8605b to 07c39a2 Compare June 24, 2024 13:57

jasonleenaylor merged commit e27a57a into develop Jun 24, 2024
9 of 10 checks passed

jasonleenaylor deleted the feature/gha-signing branch June 24, 2024 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Signing CD Action #397

Signing CD Action #397

jasonleenaylor commented Apr 17, 2024 •

edited by papeh

Loading

megahirt commented Jun 10, 2024

jasonleenaylor commented Jun 11, 2024

jasonleenaylor commented Jun 14, 2024 •

edited

Loading

megahirt left a comment

megahirt Jun 24, 2024 •

edited

Loading

rmunn Jun 24, 2024

megahirt Jun 24, 2024

rmunn left a comment

jasonleenaylor left a comment

jasonleenaylor left a comment

jasonleenaylor left a comment

		if: github.event_name != 'pull_request'


		- name: Downgrade Wix Toolset - remove when runner has 3.14.2

	- name: Downgrade Wix Toolset - remove when runner has 3.14.2
	- name: Downgrade Wix Toolset - remove when runner has 3.14.2
	# See: https://github.com/actions/runner-images/issues/9667

Signing CD Action #397

Signing CD Action #397

Conversation

jasonleenaylor commented Apr 17, 2024 • edited by papeh Loading

megahirt commented Jun 10, 2024

jasonleenaylor commented Jun 11, 2024

jasonleenaylor commented Jun 14, 2024 • edited Loading

megahirt left a comment

Choose a reason for hiding this comment

megahirt Jun 24, 2024 • edited Loading

Choose a reason for hiding this comment

rmunn Jun 24, 2024

Choose a reason for hiding this comment

megahirt Jun 24, 2024

Choose a reason for hiding this comment

rmunn left a comment

Choose a reason for hiding this comment

jasonleenaylor left a comment

Choose a reason for hiding this comment

jasonleenaylor left a comment

Choose a reason for hiding this comment

jasonleenaylor left a comment

Choose a reason for hiding this comment

jasonleenaylor commented Apr 17, 2024 •

edited by papeh

Loading

jasonleenaylor commented Jun 14, 2024 •

edited

Loading

megahirt Jun 24, 2024 •

edited

Loading