-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest Python 3.12 in Dockerfiles #3478
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3478 +/- ##
=======================================
Coverage 74.61% 74.61%
=======================================
Files 285 285
Lines 10999 10999
Branches 1338 1338
=======================================
Hits 8207 8207
Misses 2407 2407
Partials 385 385
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Fixes #3483 by building
deploy/Dockerfile
on apython:3.12.*
image rather than anubuntu:22.*
image.Look in the Commits of this pr to see how this pr was tested:
master
Also, tested the result that was pushed to https://gallery.ecr.aws/thecombine/combine_deploy by using the latest image to install The Combine on a NUC (per https://github.com/sillsdev/TheCombine/blob/master/docs/deploy/README.md#install-from-docker-image).
This change is