Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest Python 3.12 in Dockerfiles #3478

Merged
merged 11 commits into from
Dec 13, 2024
Merged

Use latest Python 3.12 in Dockerfiles #3478

merged 11 commits into from
Dec 13, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 10, 2024

Fixes #3483 by building deploy/Dockerfile on a python:3.12.* image rather than an ubuntu:22.* image.

Look in the Commits of this pr to see how this pr was tested:

  • In commit "Remove paths restriction": allowed the "Update combine_deploy image" workflow to run on this branch and that job failed
  • In commit "Add debian endpoint": finally fix everything needed for "Update combine_deploy image" to pass
  • The final commit "Restore 'on' conditions": reset the "Update combine_deploy image" workflow to only run on master

Also, tested the result that was pushed to https://gallery.ecr.aws/thecombine/combine_deploy by using the latest image to install The Combine on a NUC (per https://github.com/sillsdev/TheCombine/blob/master/docs/deploy/README.md#install-from-docker-image).

This change is Reviewable

@imnasnainaec imnasnainaec added deployment docker dependencies Pull requests that update a dependency file labels Dec 10, 2024
@imnasnainaec imnasnainaec self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.61%. Comparing base (f938b11) to head (b54faf0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3478   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files         285      285           
  Lines       10999    10999           
  Branches     1338     1338           
=======================================
  Hits         8207     8207           
  Misses       2407     2407           
  Partials      385      385           
Flag Coverage Δ
backend 83.54% <ø> (ø)
frontend 66.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec changed the title Try the latest docker/build-push-action Use latest Python 3.12 in Dockerfiles Dec 10, 2024
@imnasnainaec imnasnainaec marked this pull request as ready for review December 11, 2024 14:27
@imnasnainaec imnasnainaec requested review from andracc and removed request for andracc December 11, 2024 14:36
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 5251099 into master Dec 13, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the docker-actions branch December 13, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file deployment docker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible 11 failing in build-deploy
2 participants