Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize the : with string createProject.fileSelected #3473

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 9, 2024

Test by making sure the three updated components look right when a file is selected. Test in all 6 of our interface languages.

  • In French, there should be a space before and after the colon ( : ).
  • In Arabic, the rtl order within the interface should be: تم تحديد الملف on the right, then the colon (:) in the middle, then a space, then the filename on the left.

This change is Reviewable

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.65%. Comparing base (42000d7) to head (be0d72e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3473      +/-   ##
==========================================
- Coverage   74.69%   74.65%   -0.05%     
==========================================
  Files         285      285              
  Lines       10999    10999              
  Branches     1338     1338              
==========================================
- Hits         8216     8211       -5     
- Misses       2400     2404       +4     
- Partials      383      384       +1     
Flag Coverage Δ
backend 83.62% <ø> (-0.10%) ⬇️
frontend 66.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec added the lowpriority This might not be worked on label Dec 9, 2024
@imnasnainaec imnasnainaec self-assigned this Dec 10, 2024
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 1fed334 into master Dec 10, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the fileSelected branch December 10, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
font/language lowpriority This might not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants