Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maintenance] Support arm64 #3449

Merged
merged 6 commits into from
Nov 15, 2024
Merged

[maintenance] Support arm64 #3449

merged 6 commits into from
Nov 15, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Nov 14, 2024

For maintenance use of aws/kubectl, switch from Docker Hub (amd64 only) to AWS ECR (both amd64 and arm64).

Parallel pr: sillsdev/aws-kubectl#5


This change is Reviewable

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (b2e6fb4) to head (03d24a8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3449      +/-   ##
==========================================
- Coverage   74.63%   74.62%   -0.01%     
==========================================
  Files         285      285              
  Lines       10999    10999              
  Branches     1339     1339              
==========================================
- Hits         8209     8208       -1     
  Misses       2407     2407              
- Partials      383      384       +1     
Flag Coverage Δ
backend 83.62% <ø> (-0.02%) ⬇️
frontend 66.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec removed the request for review from andracc November 14, 2024 19:18
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec marked this pull request as draft November 15, 2024 16:41
@imnasnainaec imnasnainaec marked this pull request as ready for review November 15, 2024 18:59
@imnasnainaec imnasnainaec requested a review from andracc November 15, 2024 22:07
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 6e1b47c into master Nov 15, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the aws-kubectl branch November 15, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants