Prevent double-click recorder bug #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3414 +/- ##
==========================================
- Coverage 74.63% 74.59% -0.04%
==========================================
Files 285 285
Lines 10978 10987 +9
Branches 1335 1337 +2
==========================================
+ Hits 8193 8196 +3
- Misses 2401 2407 +6
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hahn-kev
reviewed
Nov 1, 2024
| @@ -34,6 +45,8 @@ export default function AudioRecorder(props: RecorderProps): ReactElement { | |||
| // Prevent starting a recording before a previous one is finished. | |||
| await stopRecording(); | |||
|
|
|||
| setClicked(true); | |||
There was a problem hiding this comment.
Since this is after an await it's possible that the user clicks it in-between no?
jasonleenaylor
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Dismissed @hahn-kev from a discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @hahn-kev)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3411 and prevents trying to upload an empty audio file.
Stress-test with rapid repeated clicks on the same record button. Then pause a do a normal recording on the same button.
This change is