Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Update .EditedBy when updating a Word #2718

Merged
merged 12 commits into from
Oct 26, 2023
Merged

[Backend] Update .EditedBy when updating a Word #2718

merged 12 commits into from
Oct 26, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 12, 2023

Resolves #492

Consider The Repository Pattern while refactoring.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Oct 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Files Coverage Δ
Backend/Controllers/AudioController.cs 64.38% <100.00%> (+1.00%) ⬆️
Backend/Controllers/WordController.cs 97.63% <100.00%> (-0.19%) ⬇️
src/components/DataEntry/DataEntryTable/index.tsx 62.53% <100.00%> (ø)
Backend/Services/MergeService.cs 71.15% <60.00%> (-1.07%) ⬇️
Backend/Services/WordService.cs 69.79% <91.66%> (+12.45%) ⬆️
Backend/Controllers/MergeController.cs 27.86% <0.00%> (-0.95%) ⬇️

... and 204 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@imnasnainaec imnasnainaec marked this pull request as ready for review October 23, 2023 21:45
@jasonleenaylor
Copy link
Contributor

Backend/Services/MergeService.cs line 58 at r3 (raw file):

            // Clear fields to be automatically regenerated.
            parent.Id = "";
            parent.Modified = "";

I remember this being quite important, so unless these fields are no longer cloned I would expect trouble.

Code quote:

            // Clear fields to be automatically regenerated.
            parent.Id = "";
            parent.Modified = "";

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 17 files reviewed, all discussions resolved (waiting on @imnasnainaec)


Backend/Services/MergeService.cs line 58 at r3 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

I remember this being quite important, so unless these fields are no longer cloned I would expect trouble.

It is still very important, but is now consolidated in the WordService.cs function PrepEditedData. The function (Merge) that calls this function (MergePrepParent) finishes with _wordService.Create, which invokes PrepEditedData.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 13 files at r1, 8 of 10 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 35a63cd into master Oct 26, 2023
16 checks passed
@imnasnainaec imnasnainaec deleted the editedby branch October 26, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep track of who enters what data
3 participants