-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] Update .EditedBy when updating a Word #2718
Conversation
Codecov ReportAttention:
... and 204 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
I remember this being quite important, so unless these fields are no longer cloned I would expect trouble. Code quote: // Clear fields to be automatically regenerated.
parent.Id = "";
parent.Modified = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 17 files reviewed, all discussions resolved (waiting on @imnasnainaec)
Backend/Services/MergeService.cs
line 58 at r3 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
I remember this being quite important, so unless these fields are no longer cloned I would expect trouble.
It is still very important, but is now consolidated in the WordService.cs
function PrepEditedData
. The function (Merge
) that calls this function (MergePrepParent
) finishes with _wordService.Create
, which invokes PrepEditedData
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 13 files at r1, 8 of 10 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #492
Consider The Repository Pattern while refactoring.
This change is