[ReviewEntriesActions] Fix flag not saving; Add tests for note and flag

[imnasnainaec]

Resolves "3rd of October, 2023 - Test Observations and Notes" no. 3
Resolves #2677

---

This change is 

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

Files	Coverage Δ
...viewEntriesComponent/Redux/ReviewEntriesActions.ts	63.23% <100.00%> (+0.54%)	⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

[jasonleenaylor]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

---

src/goals/ReviewEntries/ReviewEntriesComponent/tests/ReviewEntriesActions.test.tsx line 260 at r1 (raw file):

        oldRevWord.flag = newFlag(oldFlagText);
        const oldFrontierWord = mockFrontierWord();
        oldRevWord.flag = newFlag(oldFlagText);

This doesn't seem right to me. I don't see how this tests removing the flag, what am I missing?

[imnasnainaec]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

---

src/goals/ReviewEntries/ReviewEntriesComponent/tests/ReviewEntriesActions.test.tsx line 260 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

This doesn't seem right to me. I don't see how this tests removing the flag, what am I missing?

Line 263 below, await makeDispatch(mockReviewEntriesWord(), oldRevWord);, has as its first argument a word without a flag added to replace the OldRevWord which has a flag.