Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Guide] Reorganize to prepare for other languages #2354

Merged
merged 10 commits into from
Jul 18, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 7, 2023

Setup for #868


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jul 7, 2023
@imnasnainaec imnasnainaec force-pushed the user-guide-multiling-prep branch from 78f8eb0 to ed9904b Compare July 10, 2023 13:36
@imnasnainaec imnasnainaec marked this pull request as ready for review July 10, 2023 18:20
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (a517677) 61.17% compared to head (28f2bf8) 61.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2354      +/-   ##
==========================================
+ Coverage   61.17%   61.21%   +0.03%     
==========================================
  Files         238      238              
  Lines        8389     8389              
  Branches      520      520              
==========================================
+ Hits         5132     5135       +3     
+ Misses       2876     2873       -3     
  Partials      381      381              
Flag Coverage Δ
backend 73.83% <ø> (+0.06%) ⬆️
frontend 47.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imnasnainaec imnasnainaec marked this pull request as draft July 14, 2023 12:12
@imnasnainaec imnasnainaec marked this pull request as ready for review July 14, 2023 12:15
@imnasnainaec imnasnainaec requested a review from jmgrady July 18, 2023 13:08
@imnasnainaec imnasnainaec mentioned this pull request Jul 18, 2023
2 tasks
@imnasnainaec imnasnainaec enabled auto-merge (squash) July 18, 2023 13:10
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 43 of 43 files at r1, 35 of 35 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


docs/user_guide/config/en/mkdocs.yml line 4 at r1 (raw file):

theme:
  name: material
  custom_dir: "../../overrides/"

Per our discussion on Slack, we may want a name that communicates better to maintainers.

Code quote:

  custom_dir: "../../overrides/"

@imnasnainaec imnasnainaec merged commit b16c8ad into master Jul 18, 2023
@imnasnainaec imnasnainaec deleted the user-guide-multiling-prep branch July 18, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants