Skip to content

Commit

Permalink
Update ecr repo cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
imnasnainaec committed Oct 18, 2024
1 parent 23f01e3 commit e40c394
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/deploy_qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ jobs:
clean_ecr_repo:
needs: build
env:
RM_PATTERN_1: \d+\.\d+\.\d+-master\.\d+
RM_PATTERN_2: \d+\.\d+\.\d+-[a-z]+\.\d+-master\.\d+
RM_PATTERN_1: v1\.\d+\.\d+-.*
RM_PATTERN_2: v2\.0\.\d+-.*
runs-on: ubuntu-latest
steps:
# See https://docs.stepsecurity.io/harden-runner/getting-started/ for instructions on
Expand Down
2 changes: 1 addition & 1 deletion docs/deploy/kubernetes_design/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ resources are installed or reconfigured, the following jobs are created:

- `ecr-cred-helper` is a one-time Job that is run to create the `aws-ecr-credentials` Secret. The Secret type is
`kubernetes.io/dockerconfigjson` and can be used by the deployments to pull the required images from AWS ECR.
- `ecr-cred-helper-cron` refreshes the `aws-logon-credentials` periodically. The current configuration refreshes them
- `ecr-cred-helper-cron` refreshes the `aws-ecr-credentials` periodically. The current configuration refreshes them
every 8 hours.

The reason that both a one-time Job and a CronJob is so that when the cluster is first created, the pull secrets are
Expand Down

0 comments on commit e40c394

Please sign in to comment.