Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]optimize custom node BizyAir extensions JS module load #68

Closed
wants to merge 2 commits into from

Conversation

Of-qinhai
Copy link
Contributor

1.Fix JS module reference issue in ComfyUI extension bizyair within the Onebrain platform codeserver.
Onebrain platform
2.Optimize commonly used ComfyUI JS modules into _help.js for easier referencing & import .

 import { api,app,$el } from "./_help.js";

3.If new ComfyUI JS modules are utilized in the future and are missing in _help.js, they can be added accordingly.

// _help.js
let app;
let ComfyWidgets;
let api;
let $el;

@doombeaker
Copy link
Collaborator

可以补充一下示例说明吗。就是在改动前的版本,哪些情况会失效。

改变后,如何保证了原有失效情况,和现在可行的情况,都是 ok 的。

相当于简单说明下代码主要作用,麻烦了

@Of-qinhai
Copy link
Contributor Author

先别合,我好像又发现了不得了的事

@Of-qinhai Of-qinhai closed this Aug 2, 2024
@Of-qinhai Of-qinhai deleted the feat/optimize-load-js-modules branch August 2, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants