fix(math): Suppress invisible operators in MathML #2177
Merged
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omikhleia
force-pushed
the
feat-mathml-invisible-operators
branch
2 times, most recently
from
8bffb56
to
1441922
Compare
|
In particular, the MathML for the Schwinger-Dyson equation, from Josephus Javawaski's Browser Test -- which I mentioned in another issue at some point -- is now pitch perfect:
... "Achievement unlocked!" 🏅 |
alerque
force-pushed
the
feat-mathml-invisible-operators
branch
from
1441922
to
33c9fdb
Compare
alerque
approved these changes
Nov 23, 2024
alerque
approved these changes
Nov 23, 2024
|
PEG/LPEG/EPNF grammars are one place (so fat the only place?) where I don't just blindly apply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2172
As noted in the issue, the use case is not entirely clear...
Here I went for pure suppression of these operators, while respecting lspace/rspace attributes if non-zero: at least, the test cases I've checked clearly look better, and we then are also closer to what MathJax outputs for the same MathML.
So it does seem to me that's a reasonable move...