-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BibTeX types/tags are case-insensitive, etc #1478
Conversation
de7d5ec
to
bd47426
Compare
I am removing my "WIP" from the PR status - As far as I am concerned, I think this is minimally sufficient to address the original issue and get back to a "working" state on this experimental package. Needed steps to move forward out of "draft" status:
Could be an occasion to check my mappings are indeed decent enough, I have seldom used BibTeX ^^ |
Thanks for working on this. I'm considering cutting a v0.13.3 release from a patch branch because my work on v0.14.0 is quite extensive and testing it might take a little bit yet. Should this go in that? |
The Docker images are built with Arch Linux, which currently packages Gentium 6.101. Since that was built before the v0.13.2 release I would expect that to be in the Docker image. But at the end of the day it shouldn't matter what is built into Docker because our test system doesn't use any system fonts. The test system uses a hard coded list of fonts with direct download rules to get the exact versions we want, then special invocations that exclude fontconfig finding system fonts and only using the test suite list. When you update expectations you should be using the same FONTCONFIG setup as the tests use, which can be done with
Sure, glad to. Also glad to see this package getting some tests, they have been sorely lacking to date! |
I'm a bit lost in the release lifecycle, honestly (and the quick pace of some updates). Would you ask, I'd say:
|
ac0e850
to
bcf6bb3
Compare
Closes #1409
Fixes several issues:
@article
,@book
, etc. and@comment
) must be case-insensitiveauthor
,editor
,year
, etc.) must be case-insensitiveoptions
vs.options.key
) in error/warning messagesUNKNOWN_TYPE
)type()
function) and minor error check and reporting improvements.Additionally:
article
andbook
references to Chicago Citation Style 17th Editionthesis
,booklet
etc.). It's somewhat hard to map those to the Chicago style in a generic way, so it doesn't claim to be perfect, but at least the output should be reasonable.This is slightly better than what we had, anyway.