Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup SILE interface to be localized #1374

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

alerque
Copy link
Member

@alerque alerque commented Apr 18, 2022

With the tooling in place to localize, I got to thinking ... passing args to a string localizer instead of generating strings in place will actually fix the issue with unused debug messages actually slowing down our runtime. This is some initial work to swap out the internals and

a) quantify if this will enough of a gain to bother with and
b) see if it makes working with the code harder

NOT FOR CONSUMPTION, just a proof of concept.

@Omikhleia
Copy link
Member

This old PR never came to fruition as-is and now has conflicts.
Due to inactivity, and as part of backlog cleaning, I would have been tempted to close it, but the topic was interesting, and the reasons why it didn't eventually occur are unclear.
So I'm adding the "pending closure" as a label - As a last chance for contributors to eventually say their word.
After some period of time, this inactive PR will be closed without further notice.

@Omikhleia Omikhleia added the pending closure Backlog cleaning (inactive non bug-issues) label Oct 22, 2024
@alerque
Copy link
Member Author

alerque commented Oct 29, 2024

I'm still working on this. It's low priority but even in the last few weeks of radio silence on the issue tracker I've done work that furthers this along both inside SILE and it other library projects that will eventually make this easier. Some of the content here will be worth recovering when the rest of the pieces are in place.

(Having BCP-47 locale code handling and being able to apply that to the system locale ENV vars is a major missing piece not being developed for this feature but will suddenly put it within easy reach.)

@alerque alerque removed the pending closure Backlog cleaning (inactive non bug-issues) label Oct 29, 2024
@alerque alerque self-assigned this Oct 29, 2024
@alerque alerque added the enhancement Software improvement or feature request label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Software improvement or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants