Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup early merge of PR #1256 #1257

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fixup early merge of PR #1256 #1257

wants to merge 1 commit into from

Conversation

alerque
Copy link
Member

@alerque alerque commented Oct 1, 2021

Oops. I merged #1256 before I pushed the tweak I mentioned there.

@alerque alerque added this to the v0.12.x milestone Oct 1, 2021
@alerque alerque marked this pull request as draft October 1, 2021 12:50
@alerque
Copy link
Member Author

alerque commented Oct 1, 2021

This is wrong. Some cases do need a chuck() here. I'm going to keep it around because this is an interesting edge case to my last attempt to refactor pushBack(), but as it stands #1256 as merged is correct, this is not.

@alerque alerque removed this from the v0.12.x milestone Jan 12, 2022
@Omikhleia
Copy link
Member

This 3+ year old PR never came to fruition as-is and now has conflicts.
Due to inactivity, and as part of backlog cleaning, I would have been tempted to close it, but the topic was interesting, and the reasons why it didn't eventually occur are unclear.
So I'm adding the "pending closure" as a label - As a last chance for contributors to eventually say their word.
After some period of time, this inactive PR will be closed without further notice.

@Omikhleia Omikhleia added the pending closure Backlog cleaning (inactive non bug-issues) label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoncozens simoncozens Awaiting requested review from simoncozens

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pending closure Backlog cleaning (inactive non bug-issues)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alerque @Omikhleia