Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General housekeeping and go updates #3765

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jul 4, 2024

Summary

  • have a dedicated workflow for golangci-lint and add e2e to it
  • clean up ci
  • bump go to 1.22.5 in go.mod
  • update release builder to use go1.22.5

Fixes: #3760 (for golangci job)

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.71%. Comparing base (2ef6022) to head (bfcdbc7).
Report is 144 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3765      +/-   ##
==========================================
- Coverage   40.10%   36.71%   -3.39%     
==========================================
  Files         155      200      +45     
  Lines       10044    12283    +2239     
==========================================
+ Hits         4028     4510     +482     
- Misses       5530     7223    +1693     
- Partials      486      550      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpanato cpanato marked this pull request as draft July 4, 2024 16:03
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
@cpanato cpanato marked this pull request as ready for review July 5, 2024 11:55
@hectorj2f hectorj2f merged commit d05a120 into sigstore:main Jul 5, 2024
22 checks passed
@cpanato cpanato deleted the updates branch July 5, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix golangci-lint issues in the test/ directory
2 participants