Fix subnet service test #6675
Closed
Fix subnet service test #6675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Age has a PR for this here: Solution seems similar. Maybe we can combine the two? |
|
ah right yes it's the same thing with additional fixes, I'll close this one in favour of his one. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This PR fixes an intermittently failing test:
https://github.com/sigp/lighthouse/actions/runs/12246911324/job/34163756917
It fails when the validator subnets happens to be in the permanent subscriptions - the existing check doesn't actually handle this correctly as
subnet_service.is_subscribedchecks for short-lived subscription. In the case where the subnet is already subscribed as a permanent subscription, there will be no new subscription events.