Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Minor revision to Lighthouse Book on validator-manager #4638

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - Minor revision to Lighthouse Book on validator-manager #4638

wants to merge 12 commits into from

Conversation

chong-he
Copy link
Member

Correct the formatting and remove http-port 5062 to make the command simpler

@chong-he chong-he added ready-for-review The code is ready for review docs Documentation labels Aug 18, 2023
paulhauner
paulhauner approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 21, 2023
paulhauner
paulhauner requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing the latest changes, as requested ☺️

book/src/faq.md Outdated Show resolved Hide resolved
book/src/faq.md Outdated Show resolved Hide resolved
@paulhauner paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Aug 21, 2023
@chong-he chong-he added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 23, 2023
@chong-he chong-he requested a review from paulhauner August 23, 2023 11:44
@chong-he chong-he added the v4.4.1 ETA August 2023 label Aug 24, 2023
paulhauner
paulhauner reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyo, just one tiny suggestion!

I'm going to drop the v4.4.0 flag since the docs will be updated regardless of the release ☺️

book/src/faq.md Outdated Show resolved Hide resolved
@paulhauner paulhauner removed the v4.4.1 ETA August 2023 label Aug 25, 2023
@chong-he
Copy link
Member Author

Heyo, just one tiny suggestion!

I'm going to drop the v4.4.0 flag since the docs will be updated regardless of the release ☺️

Yeah I forgot it is on the unstable branch, feel free to :)

@chong-he @paulhauner
Update book/src/faq.md
c3d2f43 
Co-authored-by: Paul Hauner <[email protected]>
@chong-he chong-he requested a review from jimmygchen September 1, 2023 00:50
jimmygchen
jimmygchen approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks :)

@jimmygchen jimmygchen added do-not-merge ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 1, 2023
@jimmygchen
Copy link
Member

I've labeled as do-not-merge for now (like the other PRs) until 4.4.1 release is complete.

@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 6, 2023
@chong-he
Minor revision to Lighthouse Book on validator-manager (#4638)
291ff64 
Correct the formatting and remove `http-port 5062` to make the command simpler

Co-authored-by: chonghe <[email protected]>
@bors
Copy link

bors bot commented Sep 6, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Minor revision to Lighthouse Book on validator-manager [Merged by Bors] - Minor revision to Lighthouse Book on validator-manager Sep 6, 2023
@bors bors bot closed this Sep 6, 2023
@chong-he chong-he deleted the book-vm branch December 3, 2023 09:46
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@chong-he @Woodpile37
Minor revision to Lighthouse Book on validator-manager (sigp#4638)
e69e1b3 
Correct the formatting and remove `http-port 5062` to make the command simpler

Co-authored-by: chonghe <[email protected]>
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@chong-he @Woodpile37
Minor revision to Lighthouse Book on validator-manager (sigp#4638)
d30644f 
Correct the formatting and remove `http-port 5062` to make the command simpler

Co-authored-by: chonghe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner requested changes

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
docs Documentation ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chong-he @jimmygchen @michaelsproul @paulhauner