Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename lora mac files/classes to lorawan mac #48

Closed

Conversation

peggyopal
Copy link
Contributor

@peggyopal peggyopal commented Nov 4, 2019

This pull request works towards adding multihop functionality (issue #39)

Proposed Changes

  • Rename the following classes:
    • EndDeviceLoraMac to EndDeviceLorawanMac
    • GatewayLoraMac to GatewayLorawanMac
    • LoraMacHelper to LorawanMacHelper
    • LoraMacHeader to LorawanMacHeader
    • LoraMac to LorawanMac
  • Rename respective .cc|.h file names
  • Update doc/lorawan.rst with the new class name
  • Remove a duplicate include statement in end-device-status.h

@DvdMgr
Copy link
Member

DvdMgr commented Nov 5, 2019

Squashed, rebased, and pushed to the develop branch.

Thank you so much for this!

@DvdMgr DvdMgr closed this Nov 5, 2019
@peggyopal peggyopal deleted the rename-lora-mac-to-lorawan-mac branch November 5, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants