Add init_otel() function #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcollins
commented
Nov 19, 2024
src/splunk_otel/__init__.py
Outdated
|
|
||
|
|
||
| def init_otel(): |
There was a problem hiding this comment.
Open to suggestions on this name.
There was a problem hiding this comment.
Yeah that's more specific and probably better. Done.
johnbley
approved these changes
Nov 19, 2024
src/splunk_otel/__init__.py
Outdated
|
|
||
|
|
||
| def init_otel(): |
johnbley
reviewed
Nov 20, 2024
| | `start_otel()` | Configures tracing, metrics, and logs | None | | ||
| | Function name | Operation | Arguments | | ||
| |---------------|----------------------------------------|-----------| | ||
| | `init_otel()` | Initializes tracing, metrics, and logs | None | |
There was a problem hiding this comment.
Was this missed in the rename?
There was a problem hiding this comment.
Yes, good catch! Will fix.
There was a problem hiding this comment.
Addressed here: #547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is like the
start_tracingfunction in v1 but uses upstream's logic to initialize/configure components. Like before, does not load instrumentors (except for the system metric instrumentor which we're bundling).