Add configurator and oteltest job #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tell github to run workflow on v2 branch.
Test was incompatible with python 3.10 and up. Not worth the effort at this time to straddle compatibility between different APIs.
pmcollins
commented
Oct 31, 2024
| ep = eps.get("opentelemetry_instrumentor")[0] | ||
| assert is_system_metrics_instrumentor(ep) | ||
|
|
||
| distro_ep = eps.get("opentelemetry_distro")[0] |
There was a problem hiding this comment.
This API is different between versions of Python. Decided to remove this test for now as the benefits of this trivial test are not worth the added complexity of handling different APIs across versions of Python.
johnbley
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
SplunkConfiguratorclass which defers to upstream to perform OTel configuration. It also adds an oteltest github workflow job.