Initial setup for CI #224
Merged
Initial setup for CI #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditi-s3
commented
Dec 8, 2024
aditi-s3
commented
- Apply linting to Network, SlowDetector and CrashReports module. These have violations that need to be addressed
- Updated linting config
- Caution: Indent Rule for swiftformat is disabled as File Headers with License violate this rule and need to be addressed
- build job in CI is commented as repo is not buildable yet, once repo builds this needs to be re-visited
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
srv-gh-o11y-gdi-cla
added a commit
to splunk/cla-agreement
that referenced
this pull request
Dec 8, 2024
carlosmcevilly
approved these changes
Dec 10, 2024
| --request POST 'https://api.us-west-1.saucelabs.com/v1/storage/upload' \ | ||
| --form 'payload=@"SauceLabsTestApp.zip"' \ | ||
| --form 'name="SauceLabsTestApp.zip"' \ | ||
| --form 'description="'"$GITHUB_SHA"'"' | jq -r .item.id) |
There was a problem hiding this comment.
Do we know that jq will be installed on the build machine, or if not do we have some requirements document that lists it?
There was a problem hiding this comment.
We don't know. The saucelabs tests are currently failing in the main branch, and we need to procure a team account and fix this pipeline. Hence, for now this is removed in feature/next-gen branch
There was a problem hiding this comment.
And now I notice it was a removal, not an addition... thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.