Disable config switch #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcollins
approved these changes
Sep 22, 2023
| configuration := config.New() | ||
|
|
||
| initLogging(&configuration) | ||
|
|
||
| ossignal.Watch() | ||
|
|
||
| m := metrics.New() | ||
| var m *metrics.MetricEmitter = nil |
There was a problem hiding this comment.
Kind of a nit, especially if this library is going away, but might be nice to instead extract an interface and use a no-op implementation so we don't have to check for nil before calling methods on the variable.
There was a problem hiding this comment.
Yeah, I like that. I'll add a comment to this effect for now.
|
|
||
| shutdownCondition := registerApiAndStartMainLoop(m, &configuration) | ||
| shutdownCondition := registerApiAndStartMainLoop(enabled, m, &configuration) |
There was a problem hiding this comment.
Also a nit and just a personal style preference (it's also in Clean Code!): instead of passing in a boolean flag then modifying the behavior of the function based on its value, consider creating two separate functions.
| @@ -121,5 +140,9 @@ func initLogging(configuration *config.Configuration) { | |||
| } | |||
|
|
|||
| func extensionName() string { | |||
| return path.Base(os.Args[0]) | |||
| name := os.Getenv(extensionNameKey) | |||
There was a problem hiding this comment.
Nit: another way to write this function using Go idioms:
if name := os.Getenv(extensionNameKey); name != "" {
return name
}
return path.Base(os.Args[0])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a config environment variable to disable the collection of metrics through this extension. Owing to the rules the lambda engine places on extensions, this isn't as simple as "just exit" - you still have to Register as an extension, and ask for at least the shutdown event. Additionally, add a config switch for "extension name" to make a complicated workaround for disabling the opentelemetry collector possible.