Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Append metric labels as dimensions #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andreas-ahman
Copy link

Today the metrics contain labels that are not added as Dimensions when sent in.

for example these metrics consul.api.http

    {
      "Name": "consul.api.http",
      "Count": 1,
      "Rate": 0.034217000007629395,
      "Sum": 0.34217000007629395,
      "Min": 0.34217000007629395,
      "Max": 0.34217000007629395,
      "Mean": 0.34217000007629395,
      "Stddev": 0,
      "Labels": {
        "method": "PUT",
        "path": "v1_agent_check_update_"
      }
    }

The label method and path are not added as dimensions.

This change would allow for these labels to be added as dimensions.

@mstumpfx
Copy link

mstumpfx commented Mar 3, 2022

Hi @andreas-ahman thanks for opening - seems like a reasonable change to me.
Can you add some labels to the existing tests to verify the functionality?

@mstumpfx mstumpfx self-requested a review March 3, 2022 16:26
@mstumpfx mstumpfx self-assigned this Mar 3, 2022
@andreas-ahman
Copy link
Author

I've added the metrics in the tests. I hope it's what you're looking for.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants